stm32: cordic: merge per-call CSR writes into single register access#5663
Draft
okhsunrog wants to merge 1 commit intoembassy-rs:mainfrom
Draft
stm32: cordic: merge per-call CSR writes into single register access#5663okhsunrog wants to merge 1 commit intoembassy-rs:mainfrom
okhsunrog wants to merge 1 commit intoembassy-rs:mainfrom
Conversation
okhsunrog
force-pushed
the
cordic-optimize-csr
branch
from
bc6ba13 to
813364b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
okhsunrog
force-pushed
the
cordic-optimize-csr
branch
6 times, most recently
from
9482a6a to
f4fc85b
Compare
Contributor
Author
|
bender run |
|
|
okhsunrog
force-pushed
the
cordic-optimize-csr
branch
2 times, most recently
from
a546de2 to
5446687
Compare
Contributor
|
Ok to merge? |
okhsunrog
force-pushed
the
cordic-optimize-csr
branch
from
5446687 to
120fcbb
Compare
Contributor
Author
|
@xoviat still debugging some issues, figuring out what exactly breaks HIL |
okhsunrog
force-pushed
the
cordic-optimize-csr
branch
from
120fcbb to
83a4ecd
Compare
okhsunrog
force-pushed
the
cordic-optimize-csr
branch
from
83a4ecd to
3f364bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each CORDIC calc function (
blocking_calc_32bit,blocking_calc_16bit,async_calc_32bit,async_calc_16bit) previously made 3 separateread-modify-write cycles to configure the CSR register (NARGS, NRES,
ARGSIZE/RESSIZE). Since all CSR fields are known at call time, these
are consolidated into a single register write.
Changes
set_func,set_precision,set_scale,set_argument_count,set_result_count,set_data_width) with a singlewrite_csr()that writes all fields in one bus transactionreconfigure()from 8+ separate modify calls into 2 writesenable_write_dma/enable_read_dmainto thewrite_csrcall forasync functions, and replace separate disable calls with
disable_dma()extra_config()into a single modify