Permit writes that don't fill the entire requested buffer in {UdpSocket, IcmpSocket}::send_to_with#5641
Merged
Dirbaio merged 5 commits intoembassy-rs:mainfrom Mar 12, 2026
Conversation
lulf
approved these changes
Mar 12, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Member
Probably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #5636.
TheNevermind, found the reason: smoltcp-rs/smoltcp#964 (comment) Shouldn'tsend_to_withmethods took a&mut selffor no apparent reason (send_todoesn't and works essentially in the same way), so they have been updated to take&selfinstead. Or were the&mut selfs intentional?Udp::recv_fromalso take a mutable reference then?I've tested the UDP implementation on an ESP32 with a W5500 and it appears to work!