Fix PSRAM max_select timing (convert microseconds to femtoseconds and divide by 64 cycles)#5250
Merged
Dirbaio merged 1 commit intoembassy-rs:mainfrom Mar 13, 2026
Merged
Conversation
altundag
force-pushed
the
fix-psram-max-select-units
branch
from
457d2b8 to
96483e7
Compare
… divide by 64 cycles)
altundag
force-pushed
the
fix-psram-max-select-units
branch
from
96483e7 to
bc6c4e5
Compare
Contributor
|
The updated calculation seems to be correct. |
9names
approved these changes
Mar 13, 2026
Contributor
9names
left a comment
9names
left a comment
There was a problem hiding this comment.
Yep this looks correct, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
max_selecttiming (#5269) by correcting the units, improving memory performance.