Skip to content

add support for tab-bar mode (#21)#29

Open
Artawower wants to merge 1 commit intoemacsorphanage:masterfrom
Artawower:feat/tab-bar-mode
Open

add support for tab-bar mode (#21)#29
Artawower wants to merge 1 commit intoemacsorphanage:masterfrom
Artawower:feat/tab-bar-mode

Conversation

@Artawower
Copy link
Copy Markdown

This PR adds optional tab-bar/tabspaces-aware zoom state isolation.

When zoom-window-use-tab-bar is non-nil, zoom-window stores zoom state per tab-bar tab instead of sharing it across the whole frame. This makes zoom/unzoom
work correctly with tab-bar-based workflows, including tabspaces, where each tab should keep its own zoomed window state. It should solve the issue #21

Copilot AI review requested due to automatic review settings April 20, 2026 07:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds optional tab-bar/tabspaces-aware zoom state isolation so zoom/unzoom state is tracked per tab instead of per frame when enabled.

Changes:

  • Introduces zoom-window-use-tab-bar defcustom and tab-bar state helpers to persist per-tab zoom data.
  • Updates setup + save/restore paths to use per-tab state when tab-bar mode is enabled.
  • Adds ERT coverage for tab-bar behavior and idempotent setup.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
zoom-window.el Adds tab-bar-aware state storage and integrates it into setup and zoom state save/restore.
test/zoom-window-tab-bar-test.el Adds ERT tests validating per-tab isolation and setup hook idempotence.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread zoom-window.el
Comment thread test/zoom-window-tab-bar-test.el
Comment thread test/zoom-window-tab-bar-test.el
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants