add support for tab-bar mode (#21)#29
Open
Artawower wants to merge 1 commit intoemacsorphanage:masterfrom
Open
add support for tab-bar mode (#21)#29Artawower wants to merge 1 commit intoemacsorphanage:masterfrom
Artawower wants to merge 1 commit intoemacsorphanage:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds optional tab-bar/tabspaces-aware zoom state isolation so zoom/unzoom state is tracked per tab instead of per frame when enabled.
Changes:
- Introduces
zoom-window-use-tab-bardefcustom and tab-bar state helpers to persist per-tab zoom data. - Updates setup + save/restore paths to use per-tab state when tab-bar mode is enabled.
- Adds ERT coverage for tab-bar behavior and idempotent setup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| zoom-window.el | Adds tab-bar-aware state storage and integrates it into setup and zoom state save/restore. |
| test/zoom-window-tab-bar-test.el | Adds ERT tests validating per-tab isolation and setup hook idempotence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optional tab-bar/tabspaces-aware zoom state isolation.
When
zoom-window-use-tab-baris non-nil,zoom-windowstores zoom state pertab-bartab instead of sharing it across the whole frame. This makes zoom/unzoomwork correctly with
tab-bar-based workflows, includingtabspaces, where each tab should keep its own zoomed window state. It should solve the issue #21