fix: handle document lifecycle notifications synchronously #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition issue found while debugging elixir-lang/expert#245
In some editors(I can realiably reproduce on neovim) the client will send
textDocument/didOpenand immediately aftertextDocument/didClosewhich causes a lot of issues with Expert's Document store, and it's not trivial to fix there.Both Lexical and ElixirLS handle the specific notifications in this PR synchronously to ensure they are handled in order, per the spec.
This PR fixes that by handling lifecycle notifications synchronously. I also made the sync notifications configurable in case users have different requirements. I don't personally see which or how, but it wasn't hard to add.