Skip to content

WifiInterface: make connect_to_network independent of dialog #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 2 commits into from
Dec 20, 2025
Merged

WifiInterface: make connect_to_network independent of dialog #358

danirabbit merged 2 commits into from
Dec 20, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Dec 19, 2025 •
edited
Loading

So we can eventually create our own wifi dialog

  • Make connect_to_network to take connection, device, and access point as args instead of a dialog
  • Remove some nesting, update code style

@danirabbit danirabbit requested a review from a team December 19, 2025 17:52
@danirabbit danirabbit marked this pull request as ready for review December 19, 2025 17:52
@danirabbit danirabbit merged commit 260c3fb into master Dec 20, 2025
4 checks passed
@danirabbit danirabbit deleted the danirabbit/wifiinterface-connectnetwork-dialogagnostic branch December 20, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @leolost2605