Closed
Conversation
… messages from downstream LiveKitRoomMonitors
…token add new endpoint for sfu webhook
…new tests for ExecuteDelayedEventAction, and improve error handling.
- Consolidated test cases for missing parameters in POST requests. - Added tests for method not allowed and invalid JSON responses. - Enhanced LiveKitRoomMonitor tests to ensure proper job handling and cleanup. - Introduced new tests for Handler's loop and delayed event job processing.
…and add tests for event handling
…sts for /membership_leave_delegation endpoint
…en exiting the loop
…LiveKitRoomMonitor Loop method
…icipant is still connected): Add SFUParticipantGone signal handling and sanity check interval configuration - Introduced SFUParticipantGone signal to manage missed disconnect webhooks. - Implemented sanity check interval for participant presence verification on SFU. - Updated related tests to ensure correct handling of the new signal and configuration.
fkwp
force-pushed
the
fkwp/delegation_of_delayed_events
branch
from
9fd45d7 to
135a98d
Compare
fkwp
force-pushed
the
fkwp/delegation_of_delayed_events
branch
from
b9f4409 to
1b1fb87
Compare
…e Docker image for pull requests
fkwp
force-pushed
the
fkwp/delegation_of_delayed_events
branch
from
7bd47b2 to
7977544
Compare
fkwp
force-pushed
the
fkwp/delegation_of_delayed_events
branch
from
5ea998a to
1268c59
Compare
Contributor
Author
|
closing in favor of #171 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements "Delegated MatrixRTC Membership Lifecycle Tracking using Cancellable Delayed Events"
Once a client hands over
delay_id,delay_timeoutanddelay_cs_api_urlaDelayedEventJobis started monitoring the LiveKit WebRTC lifecycle of that participant. TheDelayedEventJobare organized per room and tracked by aLiveKitRoomMonitorThe flow is:
SFURequestis processed by the handler (processSFURequest)LiveKitRoomMonitoris acquired which gets theDelayedEventJobhanded overLiveKitRoomMonitor->DelayedEventJob