Show3D, Show3DSlices PR for alpha test and user feedback#230
Conversation
|
@ceobrero I will add a few more clean-up commits for your test. |
Show3D first public releaseShow3D, Show3DSlices PR for alpha test and user feedback
|
@dasol-yoon - for the ptycho data I shared, you can Please feel free to make a PR to |
|
@henryhng Looking for your feedback as well, at the code level if you find any inefficiencies. I will need to clean the code a bit but FPS on real-data has been my priority - espeically comapring trials across multislice ptycho recons. |
|
@cedriclim1 I initially had
|
|
Sure - I can start playing around with your widget stuff. Are you thinking since this is for Ptycho we should branch it off to |
|
Feedback from @cophus during GM
|
@cedriclim1 As we discussed in the elevator, |
@bobleesj I've noticed that when using the manual frame slider, js/colormaps.ts destroys and recreates all the GPU buffers on every frame change, so dragging the slider re-allocates per panel each step, the params/read buffers are persistent across Similarly, dragging the slider re-sends a whole frame over the message channel each step which could be slow for big frames. I think a possible fix for this could be to use the same implementation as playback, where Python pre-ships a batch of frames into a buffer that lives in JS memory so no new message per frame is needed |
|
@henryhng Thanks for this. Pushing a new stack of commits addressing performance. Will re-visit your comments. Appreciate for the findings. |
|
@bobleesj Looking at the .html file for the denoised in-situ heating series, instead of having the FOV set to the initial frame dimensions, I think it would be better to use a larger FOV that includes padding around the entire frame, so that when scrubbing through the dataset, every single frame is in full view. Right now, several frames are cropped on the sides during alignment, resulting in information loss. Frames should look something like this, where the padding is larger than the bounds of the aligned frames: After making a line profile, when I change the zoom, the line profile doesn't scale with the zoom, offsets, and clips into another quadrant: This might be personal preference, but is there a way to resize the widget so that it automatically fits into my browser dimensions? It seems set to a specific size and currently, when I click FFT it cuts offscreen, and I have to make my browser Zoom to see the color bar (my normal 100% Zoom vs. 50% Zoom): For exporting, would it be possible to have the option to also export with a scale bar? Also, exporting PNGs to a zip file and exporting a GIF either takes a really long time (progress bar?) or doesn't work, leaving "..." instead or "export". |
|
@ceobrero Thanks for testing
[next PR?] a new feature that may break existing behavior - so next PR
[next PR] Will remove export - again multi panel Show3D may break existing
[next PR] will add scale bar in the next PR |
|
I will make a few more commits in the next 1-2 and I will test and share another |
|
@bobleesj Frames still get cropped when scrubbing through the data stack: The x and y cursor coordinates seem to be flipped. Moving up and down changes the first index while moving side to side changes the second index. Turning contrast off creates four separate intensity histograms that clip into the slider: |
This is data itself. Unless you want to crop the data itself. If that's the case, we can add a function within
Going with row/col convention for STEM images. So single source of truth based on geometry.
Thanks! |
|
May 29 2026
|
|
This is slightly outdated but here are a few comments I had for improvement:
|
|
@henrygbell Thanks Henry. Most are done. Will keep you posted. |
…ne light theme, GPU perf, contrast + middle-slice fixes
feat: Show3D/Show3DSlices v2 - config calibration, gif export, offline
|
@henryhng Thanks for feedback. All fixed and kymogram added. Super useful for iterative ptycho depth res.
|
|
20260601 feedback from @cophus
|
add sliding plane for show3dslice based on Colin's feedback












What problem this PR addreseses
DRAFT
Show3D- multipleuse-case: multislice ptycho recon trial comparison, 3D denoising performance
Show3DSlices- synthetic data for now. Real-data look too good.What should the reviewer(s) do
DRAFT
draft notebooks:
show3d_simple.ipynb
show3dslices_synthetic.ipynb