Add max value for batch size windowed histograms#18850
Open
andsel wants to merge 1 commit intoelastic:mainfrom
Open
Add max value for batch size windowed histograms#18850andsel wants to merge 1 commit intoelastic:mainfrom
andsel wants to merge 1 commit intoelastic:mainfrom
Conversation
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
63ade66 to
d6fba75
Compare
💛 Build succeeded, but was flaky
Failed CI Steps
cc @andsel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Expose the max value for batch's byte_size, reported in 1,5 and 15 minutes time windows.
What does this PR do?
Update the value class to expose HdrHistogram's max value. This is used to present such value only for batch's byte_size in the stats API.
Why is it important/What is the impact to the user?
Let the user to know which is the max value for that metric that the pipeline faced in recent time windows.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Follow same instructions of #18770 .
Related issues