Open
Conversation
Contributor
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History |
Contributor
This flag is for servers start only. More details in this SKILL: https://github.com/elastic/kibana/blob/main/.agents/skills/scout-migrate-from-ftr/SKILL.md#9-verify-and-run-tests-locally |
dmlemeshko
reviewed
Mar 26, 2026
| }, | ||
| kbnTestServer: { | ||
| ...uiamConfig.kbnTestServer, | ||
| serverArgs: [...uiamConfig.kbnTestServer.serverArgs, '--cps.cpsEnabled=true'], |
Contributor
There was a problem hiding this comment.
thank you for the fix, I missed that Kibana needs a flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes for the
cps_localconfig set added in #254791:--cps.cpsEnabled=truepassed in, so CPS was never actually enabled for Kibana even though ES was starting in CPS mode.--serverConfigSetwasn't being passed through to config resolution when running tests, so specifyingcps_localwas being ignored.