Skip to content

[Dashboard] State extraction as a consistent override#259839

Draft
ThomThomson wants to merge 2 commits intoelastic:mainfrom
ThomThomson:dashboard/OverrideExtractionCleanup
Draft

[Dashboard] State extraction as a consistent override#259839
ThomThomson wants to merge 2 commits intoelastic:mainfrom
ThomThomson:dashboard/OverrideExtractionCleanup

Conversation

@ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Mar 26, 2026

Summary

Closes #257722

Root cause of the issue was that the extraction functions treated the panels and pinned_panels keys inconsistently, not providing panels as an override if a blank array was given.

Instead, this function should act as a pure override. I.e. if panels or pinned panels are given to this function it should return what it's given regardless of the count of elements in the array.

@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes v9.4.0 labels Mar 26, 2026
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 26, 2026

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!
  • Click to trigger kibana-entity-store-performance-from-pr for this PR!
  • Click to trigger kibana-storybooks-from-pr for this PR!

@ThomThomson ThomThomson added the backport:skip This PR does not require backporting label Mar 26, 2026
@ThomThomson
Copy link
Contributor Author

ThomThomson commented Mar 26, 2026

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 26, 2026 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #113 / Alerting eventLog in space default should generate expected events for flapping alerts that settle on active where notifyWhen is NOT set to "on status change"
  • [job] [logs] FTR Configs #76 / Controls Dashboard control group apply button renabling auto-apply forces filters to be published
  • [job] [logs] FTR Configs #76 / Controls Dashboard control group apply button renabling auto-apply forces filters to be published
  • [job] [logs] FTR Configs #42 / dashboard app - group 1 edit embeddable redirects redirects via save and return button after edit
  • [job] [logs] FTR Configs #42 / dashboard app - group 1 edit embeddable redirects redirects via save and return button after edit
  • [job] [logs] FTR Configs #142 / dashboard app - group 6 dashboard grid move panel Can move panel from bottom to top row
  • [job] [logs] FTR Configs #142 / dashboard app - group 6 dashboard grid move panel Can move panel from bottom to top row
  • [job] [logs] FTR Configs #4 / dashboard drilldowns Dashboard to dashboard drilldown Create & use drilldowns "before all" hook in "Create & use drilldowns"
  • [job] [logs] FTR Configs #4 / dashboard drilldowns Dashboard to dashboard drilldown Create & use drilldowns "before all" hook in "Create & use drilldowns"
  • [job] [logs] FTR Configs #78 / discover - group 3 discover saved search embeddable should allow removing the dashboard panel after the underlying saved search has been deleted
  • [job] [logs] FTR Configs #78 / discover - group 3 discover saved search embeddable should allow removing the dashboard panel after the underlying saved search has been deleted
  • [job] [logs] FTR Configs #122 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #199 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #200 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #220 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #220 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #200 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #122 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #199 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #206 / lens app - group 13 lens inline editing tests should allow inline editing of a by value visualization
  • [job] [logs] FTR Configs #206 / lens app - group 13 lens inline editing tests should allow inline editing of a by value visualization
  • [job] [logs] FTR Configs #23 / lens app - group 2 lens old color mapping runtime migrations General XY chart (Bar) should render correct "Auto Assigned" color mappings
  • [job] [logs] FTR Configs #23 / lens app - group 2 lens old color mapping runtime migrations General XY chart (Bar) should render correct "Auto Assigned" color mappings
  • [job] [logs] FTR Configs #164 / lens app - TSVB Open in Lens Convert to Lens action on dashboard should show notification in context menu if visualization can be converted
  • [job] [logs] FTR Configs #164 / lens app - TSVB Open in Lens Convert to Lens action on dashboard should show notification in context menu if visualization can be converted
  • [job] [logs] FTR Configs #94 / links panel links panel create and edit creation by-value links panel "after all" hook for "can unlink a panel from the library"
  • [job] [logs] FTR Configs #94 / links panel links panel create and edit creation by-value links panel "after all" hook for "can unlink a panel from the library"
  • [job] [logs] FTR Configs #94 / links panel links panel create and edit creation by-value links panel can save by-value links panel to the library
  • [job] [logs] FTR Configs #94 / links panel links panel create and edit creation by-value links panel can save by-value links panel to the library
  • [job] [logs] Scout: [ platform / discover_enhanced ] plugin / local-serverless-search - Discover app - saved search embeddable - should allow removing the dashboard panel after the underlying saved search has been deleted
  • [job] [logs] Scout: [ platform / discover_enhanced ] plugin / local-serverless-search - Discover app - saved search embeddable - should allow removing the dashboard panel after the underlying saved search has been deleted
  • [job] [logs] Scout: [ platform / navigation ] plugin / local-serverless-security_complete - navigation - has security serverless side nav
  • [job] [logs] Scout: [ platform / navigation ] plugin / local-serverless-security_complete - navigation - opens panel on legacy management landing page
  • [job] [logs] Scout: [ platform / custom_branding ] plugin / local-stateful-classic - custom branding - should allow setting custom logo text through advanced settings
  • [job] [logs] FTR Configs #156 / maps app dashboard reporting: creates a map report PNG file matches the baseline image, using sample geo data
  • [job] [logs] FTR Configs #156 / maps app dashboard reporting: creates a map report PNG file matches the baseline image, using sample geo data
  • [job] [logs] FTR Configs #81 / maps app save and return work flow edit existing map "before each" hook for "should use dashboard instead of time stored in map state"
  • [job] [logs] FTR Configs #81 / maps app save and return work flow edit existing map "before each" hook for "should use dashboard instead of time stored in map state"
  • [job] [logs] FTR Configs #85 / maps app tooltip filter actions panel actions should trigger dashboard drilldown action when clicked
  • [job] [logs] FTR Configs #85 / maps app tooltip filter actions panel actions should trigger dashboard drilldown action when clicked
  • [job] [logs] FTR Configs #6 / Options list control Interactions between options list and dashboard "after all" hook in "Interactions between options list and dashboard"
  • [job] [logs] FTR Configs #6 / Options list control Interactions between options list and dashboard "after all" hook in "Interactions between options list and dashboard"
  • [job] [logs] FTR Configs #6 / Options list control Interactions between options list and dashboard Test data view runtime field making selection has expected results
  • [job] [logs] FTR Configs #6 / Options list control Interactions between options list and dashboard Test data view runtime field making selection has expected results
  • [job] [logs] FTR Configs #104 / serverless search UI Building a new dashboard can access a new Dashboard from the unsaved changes section of the listing page
  • [job] [logs] FTR Configs #104 / serverless search UI Building a new dashboard can access a new Dashboard from the unsaved changes section of the listing page
  • [job] [logs] FTR Configs #175 / Visualizations - Group 10 lens app - Agg based Vis Open in Lens (heatmap) Heatmap should show the "Convert to Lens" menu item if no X-axis was specified
  • [job] [logs] FTR Configs #179 / Visualizations - Group 10 lens app - Agg based Vis Open in Lens (heatmap) Heatmap should show the "Convert to Lens" menu item if no X-axis was specified
  • [job] [logs] FTR Configs #203 / Visualizations - Group 10 lens app - Agg based Vis Open in Lens (heatmap) Heatmap should show the "Convert to Lens" menu item if no X-axis was specified
  • [job] [logs] FTR Configs #175 / Visualizations - Group 10 lens app - Agg based Vis Open in Lens (heatmap) Heatmap should show the "Convert to Lens" menu item if no X-axis was specified
  • [job] [logs] FTR Configs #203 / Visualizations - Group 10 lens app - Agg based Vis Open in Lens (heatmap) Heatmap should show the "Convert to Lens" menu item if no X-axis was specified
  • [job] [logs] FTR Configs #179 / Visualizations - Group 10 lens app - Agg based Vis Open in Lens (heatmap) Heatmap should show the "Convert to Lens" menu item if no X-axis was specified
  • [job] [logs] FTR Configs #182 / Visualizations - Group 13 (TSVB Open in Lens - Part 1) Metric should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #201 / Visualizations - Group 13 (TSVB Open in Lens - Part 1) Metric should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #204 / Visualizations - Group 13 (TSVB Open in Lens - Part 1) Metric should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #201 / Visualizations - Group 13 (TSVB Open in Lens - Part 1) Metric should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #182 / Visualizations - Group 13 (TSVB Open in Lens - Part 1) Metric should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #204 / Visualizations - Group 13 (TSVB Open in Lens - Part 1) Metric should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #166 / Visualizations - Group 14 (TSVB Open in Lens - Part 2) Dashboard to TSVB to Lens should convert a by value TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #174 / Visualizations - Group 14 (TSVB Open in Lens - Part 2) Dashboard to TSVB to Lens should convert a by value TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #187 / Visualizations - Group 14 (TSVB Open in Lens - Part 2) Dashboard to TSVB to Lens should convert a by value TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #166 / Visualizations - Group 14 (TSVB Open in Lens - Part 2) Dashboard to TSVB to Lens should convert a by value TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #174 / Visualizations - Group 14 (TSVB Open in Lens - Part 2) Dashboard to TSVB to Lens should convert a by value TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #187 / Visualizations - Group 14 (TSVB Open in Lens - Part 2) Dashboard to TSVB to Lens should convert a by value TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #2 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie should hide the "Convert to Lens" menu item if no split slices were defined
  • [job] [logs] FTR Configs #16 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie should hide the "Convert to Lens" menu item if no split slices were defined
  • [job] [logs] FTR Configs #38 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie should hide the "Convert to Lens" menu item if no split slices were defined
  • [job] [logs] FTR Configs #38 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie should hide the "Convert to Lens" menu item if no split slices were defined
  • [job] [logs] FTR Configs #2 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie should hide the "Convert to Lens" menu item if no split slices were defined
  • [job] [logs] FTR Configs #16 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie should hide the "Convert to Lens" menu item if no split slices were defined
  • [job] [logs] FTR Configs #131 / Visualizations - Group 9 lens app - Agg based Vis Open in Lens (gauge, goal, table) Gauge should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #158 / Visualizations - Group 9 lens app - Agg based Vis Open in Lens (gauge, goal, table) Gauge should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #216 / Visualizations - Group 9 lens app - Agg based Vis Open in Lens (gauge, goal, table) Gauge should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #216 / Visualizations - Group 9 lens app - Agg based Vis Open in Lens (gauge, goal, table) Gauge should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #131 / Visualizations - Group 9 lens app - Agg based Vis Open in Lens (gauge, goal, table) Gauge should show the "Convert to Lens" menu item
  • [job] [logs] FTR Configs #158 / Visualizations - Group 9 lens app - Agg based Vis Open in Lens (gauge, goal, table) Gauge should show the "Convert to Lens" menu item

History

@ThomThomson
Copy link
Contributor Author

ThomThomson commented Mar 26, 2026

/ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.4.0

Projects

None yet

Milestone

No milestone

2 participants

@ThomThomson @elasticmachine