[One Workflow] Fix validation in Test Step modal by ensuring markers are set for all editors#251714

Merged

Kiryous merged 7 commits intoelastic:mainfrom

Kiryous:15680-fix-validation-test-step-modal-v2

Feb 6, 2026

Contributor

Kiryous commented Feb 4, 2026 •

edited

Loading

Summary

Fixes validation in the Test Step modal's JSON editor by ensuring that monaco.editor.setModelMarkers is called for all Monaco editors, not just the main YAML editor.

Before

After

Screenshot 2026-02-04 at 21 15 54

Problem

The monkey patching of monaco.editor.setModelMarkers in workflow_yaml_editor.tsx was checking if the model URI matched the current editor's URI and skipping the marker setting call for non-matching editors. This prevented validation errors from being displayed in the Test Step modal's JSON editor.

Solution

The fix ensures that setModelMarkers is always called for all editors:

For the main YAML editor: markers are transformed and then set
For other editors (like Test Step modal): markers are set as-is without transformation

Changes

workflow_yaml_editor.tsx: Added call to original setModelMarkers for non-matching editors before returning
test_step_modal.tsx:
- Fixed schema binding to use current model URI
- Added data-test-subj for testing
- Cleaned up commented code
test_step_modal.stories.tsx: Added Storybook story for visual testing
workflow_yaml_editor.test.tsx: Added unit test to verify monkey patching behavior

Testing

✅ Unit test added to verify setModelMarkers is called for non-matching editors
✅ Existing tests pass
✅ Manual testing confirms validation now works in Test Step modal

Related Issue

Fixes: https://github.com/elastic/security-team/issues/15680

Kiryous and others added 2 commits

February 4, 2026 20:14


          Fix validation in Test Step modal by ensuring markers are set for all…

af19ee6

… editors

The monkey patching of monaco.editor.setModelMarkers was skipping the actual
marker setting for non-main-editor models, which prevented validation errors
from appearing in the Test Step modal's JSON editor.

This fix ensures that setModelMarkers is called for all editors, while still
applying the custom marker transformation only to the main YAML editor.

Fixes: elastic/security-team#15680
Co-authored-by: Cursor <[email protected]>


          Add unit test for monaco markers monkey patching behavior

170a318

Verifies that setModelMarkers is called for models that don't match
the current editor's URI, ensuring validation works in other Monaco
editors like the Test Step modal's JSON editor.

Co-authored-by: Cursor <[email protected]>

Kiryous requested a review from a team as a code owner

February 4, 2026 16:17

Kiryous self-assigned this

Kiryous added Team:One Workflow (do not use) backport:9.3 release-note:skip release_note:skip and removed release-note:skip labels


          fix: leftovers + zIndex

f0f74f2

Kiryous changed the title ~~Fix validation in Test Step modal by ensuring markers are set for all editors~~ [One Workflow] Fix validation in Test Step modal by ensuring markers are set for all editors

Kiryous and others added 3 commits

February 4, 2026 21:15


          fix: run button not visible in individual run

541003d


          Merge branch 'main' into 15680-fix-validation-test-step-modal-v2

887fe41


          Merge branch '15680-fix-validation-test-step-modal-v2' of https://git…

03a55f5

…hub.com/Kiryous/kibana into 15680-fix-validation-test-step-modal-v2

rosomri approved these changes

View reviewed changes

Contributor

rosomri left a comment

lgtm

Kiryous enabled auto-merge (squash)

February 5, 2026 15:15

Contributor

elasticmachine commented Feb 5, 2026

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #139 / Agent Builder tools MCP tools creating MCP tools should create an MCP tool by selecting connector and tool
[job] [logs] FTR Configs #100 / Endpoint plugin @ess @serverless @skipInServerlessMKI Endpoint policy response api GET /api/endpoint/policy_response "before all" hook for "should return one policy response for an id"

History

💚 Build #390051 succeeded 887fe41


          Merge branch 'main' into 15680-fix-validation-test-step-modal-v2

be8b052

Kiryous merged commit 24aac0c into elastic:main

17 checks passed

kibanamachine added v9.4.0 backport missing labels

Contributor

kibanamachine commented Feb 9, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

8 similar comments

Contributor

kibanamachine commented Feb 10, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 11, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 12, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 13, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 16, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 17, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 18, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 19, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 20, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

27 similar comments

Contributor

kibanamachine commented Feb 23, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 24, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 25, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 26, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Feb 27, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 2, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 3, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 4, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 5, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 7, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 9, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 10, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 11, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 12, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 13, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 16, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 17, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 18, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 19, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 20, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 23, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 24, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 25, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 26, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 27, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 30, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Contributor

kibanamachine commented Mar 31, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251714 locally
cc: @Kiryous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport missing (do not use) backport:9.3 release_note:skip Team:One Workflow v9.4.0