Skip to content

Add AcceptDocsQuery to expose per-segment AcceptDocs#139858

Open
Nawaf-TBE wants to merge 3 commits intoelastic:mainfrom
Nawaf-TBE:acceptdocs-lazy-filters
Open

Add AcceptDocsQuery to expose per-segment AcceptDocs#139858
Nawaf-TBE wants to merge 3 commits intoelastic:mainfrom
Nawaf-TBE:acceptdocs-lazy-filters

Conversation

@Nawaf-TBE
Copy link

@Nawaf-TBE Nawaf-TBE commented Dec 20, 2025

This PR introduces AcceptDocsQuery, a simple Query implementation that
exposes per-segment AcceptDocs.

This is an infrastructure-only change intended to support follow-up work
to lazily evaluate filters in flat vector codecs using the AcceptDocs
interface.

No behavior or performance changes are introduced.

Related: #137042

@cla-checker-service
Copy link

cla-checker-service bot commented Dec 20, 2025 •
edited
Loading

💚 CLA has been signed

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.4.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 20, 2025
@Nawaf-TBE
Copy link
Author

Nawaf-TBE commented Dec 20, 2025

This PR introduces AcceptDocsQuery, a simple Query implementation that exposes per-segment AcceptDocs.

This is an infrastructure-only change intended to support follow-up work to lazily evaluate filters in flat vector codecs using the AcceptDocs interface.

No behavior or performance changes are introduced.

Related: #137042

This PR intentionally limits scope to introducing AcceptDocsQuery only.
Follow-up work will integrate lazy AcceptDocs usage into flat vector codecs as discussed in #137042.

@Nawaf-TBE Nawaf-TBE closed this Dec 20, 2025
@Nawaf-TBE Nawaf-TBE reopened this Dec 20, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 23, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed needs:triage Requires assignment of a team area label labels Dec 23, 2025
benwtrent
benwtrent requested changes Jan 5, 2026
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without clear indication as to how this query would actually be used, I think this is NOT the correct direction. AcceptDocs interface is utilized directly within format APIs, I fail to see the thru-line to how a query would benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benwtrent benwtrent benwtrent requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nawaf-TBE @elasticsearchmachine @benwtrent @PeteGillinElastic