Closed
Conversation
Author
|
Hi @ezimuel Could you check and then merge this PR ? Test results (passed): https://github.com/thecaliskan/elasticsearch-php/actions/runs/16263254829/job/45913146293 |
Contributor
|
Given that v7 hasn't been supported since 9.0 came out, and considering that this PR does not add anything other than including 8.5 in the CI, I'm going to close the issue. But I recognize that v7 is still widely used, so my recommendation is that if any specific issues running this version on PHP 8.5 are discovered, a separate issue is written, so that we can evaluate if it makes sense for us to consider a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR introduces support for PHP 8.5 in conjunction with Elasticsearch 7.17. The changes ensure compatibility between the latest PHP features and the Elasticsearch client. Key updates include:
These changes were thoroughly tested to maintain the stability and reliability of the integration while leveraging the latest PHP advancements.