Add reading from DBF to DataTable#38
Open
plmmihail wants to merge 13 commits intoekonbenefits:masterfrom
Open
Conversation
With original names of columns and simple types of columns, NULL-safe.
jbtule
requested changes
Mar 4, 2021
Member
jbtule
left a comment
jbtule
left a comment
There was a problem hiding this comment.
Thanks! This looks like a useful feature. Just needs to take into account existing features.
Name of function of reading to DataTable Co-authored-by: Jay Tuley <[email protected]>
Open
Contributor
Author
And function for selecting of all fields
jbtule
requested changes
Mar 22, 2021
jbtule
requested changes
Mar 23, 2021
Member
jbtule
left a comment
jbtule
left a comment
There was a problem hiding this comment.
Just typed this into the review, might need some fixing, but should give the idea of what needs to change.
Formatting SelectAllFields() Co-authored-by: Jay Tuley <[email protected]>
Formatting _selectFields.Length Co-authored-by: Jay Tuley <[email protected]>
Simplification of NextRecord(); call Co-authored-by: Jay Tuley <[email protected]>
Simplification of NextRecord(); call Co-authored-by: Jay Tuley <[email protected]>
Preparing DataTable value cycle for a rare types of fileds like Memo or OLE. Co-authored-by: Jay Tuley <[email protected]>
Remaning ReadDataTable Co-authored-by: Jay Tuley <[email protected]>
Contributor
Author
|
Ping, @jbtule ! |
1 similar comment
Contributor
Author
|
Ping, @jbtule ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With original names of columns and simple types of columns, NULL-safe.