Skip to content

Configurable exception throwing on parsing error#33

Open
jbezak wants to merge 2 commits intoekonbenefits:masterfrom
jbezak:throwOnException
Open

Configurable exception throwing on parsing error#33
jbezak wants to merge 2 commits intoekonbenefits:masterfrom
jbezak:throwOnException

Conversation

@jbezak
Copy link

@jbezak jbezak commented Feb 21, 2020

We have a lot of cases where a high numeric value is stored in DBF which overflows the DBF limits. This is then stored as series of * and the library fails to read the record. In these case we would like to continue reading the DBF and display default value instead. This is also what DBF viewing tools are doing.

I made this configurable in NextRecord() method.

@jbezak jbezak requested a review from jbtule February 21, 2020 17:45
@jbtule
Copy link
Member

jbtule commented Mar 2, 2020

I'm thinking about this.

Leaning towards accepting it. I just have to be careful, because it's a binary breaking change.

I'm weighing between uping the version number, or changing it to an overload. I have a general preference for optional params.

@jbezak
Copy link
Author

jbezak commented Mar 2, 2020

I have no problem making it an optional param instead of overload.

Let me know your preference and I can get to this within a day or two.

@jbezak
Copy link
Author

jbezak commented Oct 6, 2020

@jbtule I came across this pull request today after long time and changed it to optional param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants