Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughAdds documentation and wiki pages for the new Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer (CLI)
participant EggBin as egg-bin (bundle)
participant Bundler as `@eggjs/egg-bundler`
participant Pack as `@utoo/pack`
participant FS as Output Dir / worker.js
Dev->>EggBin: run `egg-bin bundle` (args: --output, --mode, --framework)
EggBin->>Bundler: invoke bundle(config)
Bundler->>Bundler: load manifest (.egg/manifest.json) & resolve externals
Bundler->>Pack: run `@utoo/pack` (build)
Pack-->>Bundler: built artifacts
Bundler->>FS: write output files & bundle-manifest.json
FS-->>Dev: final outputDir and files (dev runs `node worker.js`)
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly Related PRs
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 8 minutes and 3 seconds.Comment |
Deploying egg with
|
| Latest commit: |
4b80740
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://063e7669.egg-cci.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-434f8fd6.egg-cci.pages.dev |
There was a problem hiding this comment.
Code Review
This pull request introduces the @eggjs/egg-bundler package and adds a bundle command to egg-bin, with documentation provided in READMEs and the project wiki. The feedback recommends removing the meta-commentary in the 'Inference' section of the wiki documentation to maintain a professional public-facing document.
Deploying egg-v3 with
|
| Latest commit: |
4b80740
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b7403631.egg-v3.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-434f8fd6.egg-v3.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for the new Egg bundling tooling, covering both the egg-bin bundle CLI surface and the underlying @eggjs/egg-bundler package, and records the package in the repository’s wiki index/log for future maintenance.
Changes:
- Document
egg-bin bundleusage and flags intools/egg-bin/README.md. - Add
tools/egg-bundler/README.mddescribing the programmatic API, options, results, and runtime behavior. - Add/record
@eggjs/egg-bundlerin the wiki index/log with a package page.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| wiki/packages/egg-bundler.md | Adds a wiki package page describing bundler surfaces/flow and behavior notes. |
| wiki/log.md | Adds a log entry for the bundler documentation update. |
| wiki/index.md | Adds the bundler page link to the wiki package index. |
| tools/egg-bundler/README.md | Introduces a package README with API usage/options/results and runtime notes. |
| tools/egg-bin/README.md | Documents the new bundle command and its CLI options. |
Summary
egg-bin bundlecommand intools/egg-bin/README.md.@eggjs/egg-bundlerwith usage, options, result fields, and runtime notes.Validation
git diff --cached --checkpassed before commit.pnpm exec oxfmt --check tools/egg-bin/README.md tools/egg-bundler/README.md wiki/index.md wiki/log.md wiki/packages/egg-bundler.mdcould not run because this worktree has no installed dependencies andoxfmtwas not available.Summary by CodeRabbit
egg-bin bundleCLI and programmatic API, options (mode, framework, externals control), output/resolution behavior, and how to run generated artifacts.