feat: add enterprise-access to devstack #87
Conversation
iamsobanjaved
force-pushed
the
iamsobanjaved/enterprise-access
branch
from
3769273 to
47c0f3a
Compare
| networks: | ||
| default: | ||
| aliases: | ||
| - edx.devstack.enterprise-access |
There was a problem hiding this comment.
Do we need this... as it's already in the same docker-compose file?
There was a problem hiding this comment.
Yup, it is there to define its alias. Also present in other IDAs in this docker-compose.yml file.
| networks: | ||
| default: | ||
| aliases: | ||
| - edx.devstack.enterprise-access-worker |
| echo -e "${GREEN}Creating super-user for ${name}...${NC}" | ||
| docker compose exec -T ${name} bash -e -c "echo 'from django.contrib.auth import get_user_model; User = get_user_model(); User.objects.create_superuser(\"edx\", \"[email protected]\", \"edx\") if not User.objects.filter(username=\"edx\").exists() else None' | python /edx/app/enterprise-access/manage.py shell" -- "$name" | ||
|
|
||
| ./provision-ida-user.sh ${name} ${name} ${port} |
There was a problem hiding this comment.
Might need to update it as in the upcoming line
we're accessing user using this line
User.objects.get(username=\"${name}_worker\")
There was a problem hiding this comment.
It is already adding _worker postfix here:
devstack/provision-ida-user.sh
Line 16 in 731be3f
|
|
||
| docker-compose up -d $name | ||
|
|
||
| # Run migrations |
There was a problem hiding this comment.
Are we going to use the following convention here
https://github.com/edx/devstack/blob/master/provision-notes.sh#L15
If yes, then we need to remove this line
https://github.com/edx/public-dockerfiles/blob/main/dockerfiles/enterprise-access.Dockerfile#L121
provision-enterprise-access.sh
Outdated
|
|
||
| # Restart enterprise.catalog app and worker containers | ||
| # docker-compose restart app | ||
| make dev.restart-devserver.enterprise-access No newline at end of file |
There was a problem hiding this comment.
Nit: blank line needed
iamsobanjaved
force-pushed
the
iamsobanjaved/enterprise-access
branch
from
47c0f3a to
e671bd5
Compare
I've completed each of the following or determined they are not applicable: