feat: add license manager ida to devstack #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumarkhan999
force-pushed
the
umar/add-license-manager-ida
branch
8 times, most recently
from
51d3e3a to
25d0e57
Compare
mumarkhan999
force-pushed
the
umar/add-license-manager-ida
branch
16 times, most recently
from
bef5619 to
79cae04
Compare
iamsobanjaved
approved these changes
Dec 2, 2024
Contributor
iamsobanjaved
left a comment
iamsobanjaved
left a comment
There was a problem hiding this comment.
Just one comment, rest looks good 👍
provision-license-manager.sh
Outdated
Contributor
There was a problem hiding this comment.
Don't you think it should be this, because it is already adding the above-mentioned postfix here
./provision-ida-user.sh ${name} ${name} ${port}
Contributor
Author
There was a problem hiding this comment.
Copied this line here
https://github.com/openedx/license-manager/blob/master/provision-license-manager.sh#L38
mumarkhan999
force-pushed
the
umar/add-license-manager-ida
branch
from
79cae04 to
6187980
Compare
mumarkhan999
force-pushed
the
umar/add-license-manager-ida
branch
from
6187980 to
36df964
Compare
mumarkhan999
force-pushed
the
umar/add-license-manager-ida
branch
from
36df964 to
48f2763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue