feat: implement new UI layout & apply some improvements#4
Open
bra-i-am wants to merge 12 commits intodam/catalog_detailsfrom
Open
feat: implement new UI layout & apply some improvements#4bra-i-am wants to merge 12 commits intodam/catalog_detailsfrom
bra-i-am wants to merge 12 commits intodam/catalog_detailsfrom
Conversation
bra-i-am
changed the title
dcoa
reviewed
Jan 27, 2026
dcoa
reviewed
Jan 27, 2026
dcoa
reviewed
Feb 2, 2026
dcoa
reviewed
Feb 4, 2026
There was a problem hiding this comment.
Please regenerate the package-lock.json too otherwise the code fail with npm ci
dcoa
requested changes
Feb 5, 2026
There was a problem hiding this comment.
After that changes and solving the package-lock.json and the env files I think we are good to go with this PR.
Also could you please add this CORPORATE_MANAGER_MFE_BASE_URL to the env files and the index.jsx in the merge config? That will help to future developers to identify the needed MFE Config for this particular MFE.
Note: there are lint issues as well to take in consideration
src/learningpath/index.css
Outdated
There was a problem hiding this comment.
Please delete this style as is not relevant for us.
| } | ||
|
|
||
| .pgn__card-wrapper-image-cap { | ||
| .pgn__card-image-cap { |
There was a problem hiding this comment.
I think we should override paragon style and use:
object-fit: contain
dcoa
reviewed
Feb 5, 2026
src/learningpath/index.css
Outdated
… for text strings - Integrated `useIntl` from `@edx/frontend-platform/i18n` across multiple components including CourseCard, CourseDetails, Dashboard, DataSharingAuthorizationModal, FilterPanel, LearningPathCard, and LearningPathDetails. - Created a new messages file to define all text strings used in the learning path components for better localization support. - Replaced hardcoded strings with formatted messages to enhance maintainability and support for multiple languages.
bra-i-am
force-pushed
the
bc/implement-new-ui
branch
from
d838e03 to
d089dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves several components in the learning path feature, focusing on code clarity, UI consistency, and enhanced user experience. The most significant changes include a major overhaul of the
LearningPathCardlogic and UI, updates to button variants and icon usage for consistency, and improvements to header layouts in the dashboardChecklist
corporate-managerto/{partnerSlug}/catalogs/{catalogSlug}/courses/How to test
Note
Make sure you have corporate partners with partner catalogs assigned to it, and add some courses to it so you can test it better
npm run devMFE_CONFIGtutor dev exec lms reload-uwsgiortutor dev restart lmsScreencast
Screencast.from.23-01-26.11.19.04.webm