Docs/fdb 504 envvar

[ChrisspyB]

Description

Depends on #229.

Does the following:

• Adds env var FDB_SUB_TOCS which from now should be preferred over FDB5_SUB_TOCS.
• Removed the var FDB5_SKIP_REMOTE_PROTOCOL_SANITY_CHECK and related code.
  • Because I do not believe there is a reason to not validate the protocol versions being used.
• Added some documentation to FDB_SUB_TOCS.
  • These ought to link to a more general discussion about tocs, subtocs and the POSIX backend to FDB in general, if such a page exists.

Contributor Declaration

By opening this pull request, I affirm the following:

• All authors agree to the Contributor License Agreement.
• The code follows the project's coding standards.
• I have performed self-review and added comments where needed.
• I have added or updated tests to verify that my changes are effective and functional.
• I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-230

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-230

[codecov-commenter]

Codecov Report

❌ Patch coverage is 43.47826% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.54%. Comparing base (2a648d1) to head (8e64b97).

Files with missing lines	Patch %	Lines
src/fdb5/remote/FdbServer.cc	0.00%	8 Missing ⚠️
src/fdb5/LibFdb5.cc	16.66%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #230      +/-   ##
===========================================
- Coverage    73.55%   73.54%   -0.01%     
===========================================
  Files          363      363              
  Lines        22044    22049       +5     
  Branches      2260     2262       +2     
===========================================
+ Hits         16214    16217       +3     
- Misses        5830     5832       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.