Feature/fdb 327 fdb compare #165
Open
+2,600
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This was supposed to be a draft pull request.... |
dsarmany
force-pushed
the
feature/FDB-327-fdb-compare
branch
from
684c81d to
722f460
Compare
pgeier
force-pushed
the
feature/FDB-327-fdb-compare
branch
from
722f460 to
38d2604
Compare
stefaniereuter
force-pushed
the
feature/FDB-327-fdb-compare
branch
from
7b4aaf0 to
232d0b2
Compare
pgeier
force-pushed
the
feature/FDB-327-fdb-compare
branch
from
d6efd5d to
957b3c0
Compare
pgeier
force-pushed
the
feature/FDB-327-fdb-compare
branch
3 times, most recently
from
f6064e4 to
c814917
Compare
|
Pending tasks:
|
pgeier
force-pushed
the
feature/FDB-327-fdb-compare
branch
from
c814917 to
2daf3e2
Compare
…wo FDB no comparison or testing done yet
…nore certain key-value pairs
pgeier
force-pushed
the
feature/FDB-327-fdb-compare
branch
from
bcef5ed to
b643bc8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #165 +/- ##
===========================================
- Coverage 73.30% 72.66% -0.64%
===========================================
Files 363 377 +14
Lines 21956 22712 +756
Branches 2253 2383 +130
===========================================
+ Hits 16094 16504 +410
- Misses 5862 6208 +346 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pgeier
force-pushed
the
feature/FDB-327-fdb-compare
branch
from
3508d48 to
1b031b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening this as a draft pull request, while finishing the refactoring on the grib comparison but to start discussing the design and features.
This draft shows the direction in which I would like to continue refactoring.
This tool allows to compare two FDB or two experiments in one FDB. It uses the standard fdb tool mechanisms, minimal-keys, CLI request, but also allows to directly specify mars keys, where entries should be ignored. it uses fdb list to generate a request then sorts the results and compares them, depending on scope, where the default is just a comparison of the mars keys, without the messages itself, possibility of comparing grib-header only and then grib-header plus data section. Default is a key by key comparison,
More explanation and examples can be found here:
https://confluence.ecmwf.int/display/~ecm4053/FDB+Comparison
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-165
🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-165
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-165