feat(models, training): Optimise spectral transform#985
Draft
samhatfield wants to merge 9 commits intomainfrom
Draft
feat(models, training): Optimise spectral transform#985samhatfield wants to merge 9 commits intomainfrom
samhatfield wants to merge 9 commits intomainfrom
Conversation
OpheliaMiralles
previously approved these changes
Mar 19, 2026
Contributor
OpheliaMiralles
left a comment
There was a problem hiding this comment.
Looks ok in theory. I'm not personally using the SpectralL2Loss but it shouldn't make any difference
Collaborator
Author
|
Sorry I should have marked it as a draft... I'm not sure what the etiquette is for anemoi PRs. This is not yet ready for merging. Still playing around with a few things offline and consulting people in other channels to make sure what I'm doing here is okay. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements two optimisations to spectral transforms:
What problem does this change solve?
Optimisation 1
The L2 spectral loss is currently computed like the following:
A spectral transform is a linear operation, so it's not necessary to transform each field individually. Instead you can just transform the residual itself, which reduces the number of calls to
_to_spectral_flatfrom two to one:This improves overall speed of training when spectral losses are used at N320 by about 5%.
Optimisation 2
For classic reduced grids like N320, many latitudes have the same length. It makes sense to group these together into a batch and execute a batched FFT.
This provides a further ~20% of performance improvement for N320.
Note that optimisation 2 does nothing for octahedral grids which have different length FFTs at each latitude. There, graphs are still the best solution.
What issue or task does this change relate to?
#599 #974
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.