Open
Conversation
JPXKQX
changed the title
fprill
force-pushed
the
fix/icon_mesh_vertex_mask
branch
from
b588c8e to
dcd1c41
Compare
JPXKQX
approved these changes
Mar 30, 2026
Member
JPXKQX
left a comment
JPXKQX
left a comment
There was a problem hiding this comment.
It looks good to me! Thanks Florian!
github-project-automation
bot
moved this from To be triaged
to For merging
in Anemoi-dev
Member
|
@fprill does the bug point to a missing test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug-fix: Fixes cell-to-vertex indexing during coarsening of ICON meshes.
What problem does this change solve?
In the AICON encoder, edges are constructed between cell circumcenters (representing data points) and the three vertices of the enclosing hidden mesh triangle. However, a critical bug was introduced during recent refactorings of
icon_mesh.py: Invalid edges were generated and edge shard partitions became empty due to incorrect indexing.What issue or task does this change relate to?
none (bug-fix)