Draft
Conversation
Contributor
|
nice, the benchmark tests pass |
Member
Author
|
waiting for #931 to be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the sharding metadata used to track tensor shapes across ranks.
Previously, we stored the full tensor shape for each rank (e.g. list[list[int]]). This required layers to manually track reshapes and dimension changes whenever tensors were transformed, which made the sharding logic fragile and tightly coupled to tensor layouts.
This refactor introduces
ShardSizes = Union[list[int], None], representing the per-rank shard sizes along only the sharded dimension. Layers now propagate this information through a bundledGraphShardInfo/BipartiteGraphInfowhich tracks shard metadata for both nodes and edges. The full shape expansion only happens at the level of the communication primitive where shapes are assumed equal for non-sharded dimensions across ranks.Also refactor the all-to-all primitives for head/channel <-> grid sharding into a single common all-to-all primitive.
Additional notes
For now I've tested sharding for a global model across combinations of:
please feel free to also test your favourite use case.
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.