fix(models): revisions triton gt kernel to improve stability#1027
Draft
fix(models): revisions triton gt kernel to improve stability#1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve numerical stability of the Triton GT kernel. However, this results in a ~ 10% memory increase and a similar % in terms of performance degradation (pure kernel - less in a real training run). Tests.
blue: current triton kernel bf16
red: current triton kernel bf16, second try
green: resume blue curve with pyg compiled bf16
orange: pyg compiled bf16
violet: pyg compiled bf16, cast to float32
brown: revised triton kernel bf16
test:
|dq| / |dk|