Check for expected ZID when opening scouted links#2579
Open
oteffahi wants to merge 3 commits intoeclipse-zenoh:mainfrom
Open
Check for expected ZID when opening scouted links#2579oteffahi wants to merge 3 commits intoeclipse-zenoh:mainfrom
oteffahi wants to merge 3 commits intoeclipse-zenoh:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
==========================================
- Coverage 74.85% 74.69% -0.17%
==========================================
Files 399 399
Lines 59401 59564 +163
==========================================
+ Hits 44467 44489 +22
- Misses 14934 15075 +141 ☔ View full report in Codecov by Sentry. |
evshary
approved these changes
Apr 21, 2026
Contributor
evshary
left a comment
There was a problem hiding this comment.
LGTM, but maybe you want to retrigger the CI. Something might go wrong in the CI server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes scouted connections validate that the peer ZID matches what was advertised in scouting.
It can also be leveraged to improve multilink for
clientmode by making sure all endpoints belong to the same ZID (to be implemented as part of #2320)Why is this change needed?
It fixes possible attacks described in #2151
Related Issues
Fixes #2151
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
bug🐛 Bug Fix Requirements
Since this PR is labeled as a bug fix, please ensure:
Why this matters: Bugs without tests often reoccur.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.