Replace RwLock by OnceLock for transport callback#2381
Merged
OlivierHecart merged 2 commits intoMay 12, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2381 +/- ##
==========================================
+ Coverage 71.91% 72.47% +0.55%
==========================================
Files 390 390
Lines 62764 63283 +519
==========================================
+ Hits 45139 45864 +725
+ Misses 17625 17419 -206 ☔ View full report in Codecov by Sentry. |
1b8a25a to
5f5ad96
Compare
b8700c3 to
f7ac78d
Compare
OlivierHecart
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback is set only once after the transport creation. Using the right primitive, e.g. a OnceLock gives better performance, as it just do an atomic load instead of a atomic RMWs of RwLock.
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
internal🏠 Internal Change
This PR is marked as internal (not user-facing):
Lighter review: Internal changes may have lighter review requirements.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.