Converted generator into an ESM package, bumped yeoman-generator dependency to vision ^7.0.0#188
Open
sailingKieler wants to merge 2 commits intoeclipse-theia:masterfrom
Open
Conversation
6849175 to
c44e654
Compare
ef0d095 to
563f11f
Compare
Contributor
Author
|
As indicated by the original title, I've prepared another change bumping to |
…erator to ^6.0.0 bumped typescript version to ~4.7.0 to be able to * set tsConfig options 'module' and 'moduleResolution' to value of 'Node16', see https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html * deal with the transitive dependency 'mem-fs-editor' in version 10.0.x containing function alias assignments including type argument assignments, see https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#instantiation-expressions Signed-off-by: Christian Schneider <christian.schneider@typefox.io>
563f11f to
6659779
Compare
Contributor
Author
|
Since the ci build is now using Node18 (#193) I updated this branch and added my additional commit bumping the dependency of |
* upgraded the dependency of 'yeoman-test' already to '^8.0.0' because of a problematic dependency in '^7.0.0' (mem-fs-editor@9.x...', has been by 'mem-fs-editor@10.y...') * added a 'resolution' on 'mem-fs@4.0.0', as that dependency is only referenced as peer-dependency by all up-to-date versions of using packages - which are not installed by yarn (in contrast to npm) -, but it's required at runtime; filed a request on Github to add 'mem-fs@4.0.0' as a prod dependency to 'yeoman-generator': yeoman/generator#1495; besides 'yeoman-test@8.2.0' insists on 'mem-fs-editor@^10.0.3' (which depends on 'mem-fs@^3.0.0'), both declare "acceptDependencies" { "mem-fs": "^4.0.0" } - which again is not considered by yarn Signed-off-by: Christian Schneider <christian.schneider@typefox.io>
6659779 to
99b4555
Compare
Contributor
|
Cool, just to make sure: have you tested all templates whether they work as expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As announced in the dev meeting yesterday - and although I don't see any urgency to merge it ASAP - here's my additional work on the generator:
converted generator into an ESM package, bumped version of yeoman-generator to ^6.0.0
bumped version of 'yeoman-generator' to ^7.0.0
besides 'yeoman-test@8.2.0' insists on 'mem-fs-editor@^10.0.3' (which depends on 'mem-fs@^3.0.0'), both declare "acceptDependencies" { "mem-fs": "^4.0.0" } - which again is not considered by yarn