Skip to content

[1986] Make ServiceMethod fail if parameters don't match arity#1987

Merged
AxelRICHARD merged 1 commit intomainfrom
gda/enh/serviceMethodFailFast
Feb 12, 2026
Merged

[1986] Make ServiceMethod fail if parameters don't match arity#1987
AxelRICHARD merged 1 commit intomainfrom
gda/enh/serviceMethodFailFast

Conversation

@gdaniel
Copy link
Contributor

@gdaniel gdaniel commented Feb 11, 2026

Bug: #1986

Fixes #1986

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gdaniel
Copy link
Contributor Author

gdaniel commented Feb 11, 2026

I felt this improvement was too technical to add an entry in the release notes.
Let me know if I should add one.

Copy link
Member

@AxelRICHARD AxelRICHARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@AxelRICHARD
Copy link
Member

I felt this improvement was too technical to add an entry in the release notes. Let me know if I should add one.

You're absolutely right. Thank you!

@AxelRICHARD AxelRICHARD merged commit c1b99da into main Feb 12, 2026
7 checks passed
@AxelRICHARD AxelRICHARD deleted the gda/enh/serviceMethodFailFast branch February 12, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ServiceMethod#aql fail fast if arity doesn't match the provided parameters

2 participants