fix(rest): restricting modification of fields.#4058
Open
rudra-superrr wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
fix(rest): restricting modification of fields.#4058rudra-superrr wants to merge 1 commit intoeclipse-sw360:mainfrom
rudra-superrr wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
rudra-superrr
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
rudra-superrr
added
needs code review
needs general test
Signed-off-by: rudra-superrr <prabhuchopra@gmail.com>
rudra-superrr
force-pushed
the
fix/patch_endpoints
branch
from
f0681c2 to
31c4932
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The PATCH endpoints for Components (PATCH /api/components/{id}) and Projects (PATCH /api/projects/{id}) currently allow users to overwrite immutable creation metadata fields:
Component/Project level: createdOn, createdBy
Attachment level: createdBy, createdTeam, createdOn
These fields are set at creation time and should not be modifiable afterwards. A user can currently send arbitrary values for these fields in a PATCH request body, and they will be persisted .
How to test:
Attempt to modify the above fields via patch endpoint.