fix(externalIds): handle package-url stored as JSON array string#1617
Open
bibhuti230185 wants to merge 3 commits intoeclipse-sw360:mainfrom
Open
fix(externalIds): handle package-url stored as JSON array string#1617bibhuti230185 wants to merge 3 commits intoeclipse-sw360:mainfrom
bibhuti230185 wants to merge 3 commits intoeclipse-sw360:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Old SW360 backend stored multiple
package-urlvalues as a single JSON array string (e.g.,["pkg:maven/...", "pkg:npm/..."]). The new UI could not properly display, edit, or save these entries.Problem
Solution
Modified 3 files to handle the JSON array format:
src/utils/common.utils.tsconvertObjectToMap()now expandspackage-urlJSON arrays into multiple entries when readingsrc/components/sw360/AddKeyValue/AddKeyValue.tsxconvertListToMap()that merges multiplepackage-urlentries back into JSON array when savingsrc/components/ExternalIds/ExternalIds.tsxexpandExternalIds()to display each package URL on its own lineTesting
package-url: ["pkg:maven/org.apache.commons/[email protected]","pkg:npm/@angular/[email protected]"]Edge Cases Handled
[]- no entries createdtrimStart()