Skip to content

fix(ExportSpreadsheet): Fixed export spreadsheet in project with search results#1615

Open
Farooq-Fateh-Aftab wants to merge 2 commits intoeclipse-sw360:mainfrom
siemens:fix/exportProjectSpeadsheetWithSearchResult
Open

fix(ExportSpreadsheet): Fixed export spreadsheet in project with search results#1615
Farooq-Fateh-Aftab wants to merge 2 commits intoeclipse-sw360:mainfrom
siemens:fix/exportProjectSpeadsheetWithSearchResult

Conversation

@Farooq-Fateh-Aftab
Copy link
Copy Markdown
Contributor

Please provide a summary of your changes here.

Issue: #1614

Suggest Reviewer

@GMishx , @amritkv

How To Test?

1. Navigate to Project Tab.
2. Search with Advance filter.
3. Export the spreadsheet with both option, excel will have the same result as shown in UI after search.

Comment on lines +578 to +579
const searchParams = Object.fromEntries(params.entries())
const searchParamsString = new URLSearchParams(searchParams).toString()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Farooq-Fateh-Aftab !
We can combine these 2 lines into one liner.
It could be like const searchParamsString = params.toString() instead of doing params → object → string.
The current approach is suitable when we need to modify the param, but here it's not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants