fix(ExportSpreadsheet): Fixed export spreadsheet in project with search results#1615
Open
Farooq-Fateh-Aftab wants to merge 2 commits intoeclipse-sw360:mainfrom
Open
Conversation
amritkv
requested changes
Apr 11, 2026
Comment on lines
+578
to
+579
| const searchParams = Object.fromEntries(params.entries()) | ||
| const searchParamsString = new URLSearchParams(searchParams).toString() |
Member
There was a problem hiding this comment.
Hey @Farooq-Fateh-Aftab !
We can combine these 2 lines into one liner.
It could be like const searchParamsString = params.toString() instead of doing params → object → string.
The current approach is suitable when we need to modify the param, but here it's not the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1614
Suggest Reviewer
How To Test?