Skip to content

Trim console lines that are longer than limit #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
trancexpress wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Draft

Trim console lines that are longer than limit #2466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/IOConsoleTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ public void testTrim() throws Exception {

c.getConsole().setWaterMarks(50, 100);
c.waitForScheduledJobs();
c.verifyContentByOffset("0123456789", 0);
c.verifyContentByOffset("0123456789", 1);
assertTrue(c.getDocument().getNumberOfLines() < 15, "Document not trimmed.");
}
closeConsole(c);
Expand Down
2 changes: 2 additions & 0 deletions debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,6 +1203,8 @@ private void trim(int truncateOffset, boolean truncateToOffsetLineStart) {
if (truncateToOffsetLineStart) {
int cutoffLine = document.getLineOfOffset(truncateOffset);
cutOffset = document.getLineOffset(cutoffLine);
// deal with case of one long line
cutOffset = Math.max(cutOffset, truncateOffset);
}
if (cutOffset >= length) {
updateType = DocUpdateType.TRIM;
Expand Down
Loading