Skip to content

Replace GIF icons with SVGs in example.navigator project#3734

Draft
vogella wants to merge 12 commits intoeclipse-platform:masterfrom
vogella:example-gif-replacement-with-svg
Draft

Replace GIF icons with SVGs in example.navigator project#3734
vogella wants to merge 12 commits intoeclipse-platform:masterfrom
vogella:example-gif-replacement-with-svg

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Feb 17, 2026

  • Copied delete_obj.svg, filenav_nav.svg, and prop_ps.svg from workbench bundles.
  • Updated plugin.xml to reference the new SVG icons.
  • Removed the original GIF files.
  • Updated build.properties to include the icons directory in the binary build.

- Copied delete_obj.svg, filenav_nav.svg, and prop_ps.svg from workbench bundles.
- Updated plugin.xml to reference the new SVG icons.
- Removed the original GIF files.
- Updated build.properties to include the icons directory in the binary build.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Test Results

 3 024 files  + 54   3 024 suites  +54   2h 25m 46s ⏱️ +20s
 8 234 tests ±  0   7 986 ✅ ±  0  248 💤 ± 0  0 ❌ ±0 
23 526 runs  +170  22 735 ✅ +114  791 💤 +56  0 ❌ ±0 

Results for commit 42da72a. ± Comparison against base commit 676351a.

♻️ This comment has been updated with latest results.

@BeckerWdf
Copy link
Member

but (at least some) icons are completely different. Is that by intention?

@vogella
Copy link
Contributor Author

vogella commented Feb 17, 2026

but (at least some) icons are completely different. Is that by intention?

I searched for fitting icons with the same name, as these are examples and are not visible in an Eclipse installation I did not care too much if some of them look different.

@BeckerWdf
Copy link
Member

can we get a before vs. after screenshot

@vogella
Copy link
Contributor Author

vogella commented Feb 17, 2026

can we get a before vs. after screenshot

Sure, I will split the PR into individual PR per project and add before and after screenshos.
I will do this after the freeze, not time critical as the current gifs have been ugly since a decade on a darker background.

@vogella vogella marked this pull request as draft February 17, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants