Always show Installable Unit (IU) ID in target editor#2208
Always show Installable Unit (IU) ID in target editor#2208vogella wants to merge 2 commits intoeclipse-pde:masterfrom
Conversation
HannesWell
left a comment
There was a problem hiding this comment.
This is a difficult one.
On one hand I understand the desire to see the ID and it looks good.
On the other hand the concern from Christoph from #1432 (comment) is also valid.
I have to think about this.
Do others have opinions?
|
Yes, on the downside it's very verbose. It could be shown in a hover instead... It's also significant to note that the ID available directly in the source, whereas the name and the version are not. But the association between the ID in the source versus the arbitrary name is also not shown anywhere currently... |
|
I just wanted to point out that code annotations are a powerful feature for such purpose as "showing a problem in the source" or even additional information (like the name). And as the target editor already use them (e.g. to provide set as active target) it might maybe be a better alternative for the proposed use-case. Also a |
|
Another idea might be adding a toggle button "export mode" / "simple mode" to the button list next to the locations part in the target editor that would add the desired IDs to the editor's tree view or hide them. I do also like the idea of having a rightclick->show in source feature. |
a985b63 to
d5a9bd2
Compare
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
993fbaf to
1a97b5c
Compare
Modified StyledBundleLabelProvider to always display the technical ID of Installable Units in the Target Platform Editor's Definition and Content tabs. If a descriptive name exists and differs from the ID, both are shown (Name [ID]), otherwise just the ID is displayed. Fixes eclipse-pde#1432
1a97b5c to
37c9cc1
Compare
Modified StyledBundleLabelProvider to always display the technical ID of Installable Units in the Target Platform Editor's Definition and Content tabs. If a descriptive name exists and differs from the ID, both are shown (Name [ID]), otherwise just the ID is displayed.
Fixes #1432