Fix flaky PluginBasedLaunchTest by waiting for jobs and UI #2205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PluginBasedLaunchTest.testWriteBundleEntry_singleTargetPlugin_noVersionEntry failure appears to be a real issue caused by asynchronous updates to the plugin registry or target platform not completing before the test assertion. This change adds a waitForJobsAndUI helper method to AbstractLaunchTest.java and invokes it within the getModel method. This ensures that the test waits for background jobs and processes the UI event loop, allowing the target platform to be fully loaded before asserting the model's presence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PluginBasedLaunchTest.testWriteBundleEntry_singleTargetPlugin_noVersionEntry failure appears to be a real issue caused by asynchronous updates to the plugin registry or target platform not completing before the test assertion.
This change adds a waitForJobsAndUI helper method to AbstractLaunchTest.java and invokes it within the getModel method. This ensures that the test waits for background jobs and processes the UI event loop, allowing the target platform to be fully loaded before asserting the model's presence.