Fix performance issue and infinite loop in classpath computation #2204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please add meaningful title and descriptions see https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#using-draft-pull-requests before opening draft PRs. |
Test Results 135 files - 663 135 suites - 663 12m 16s ⏱️ - 48m 54s Results for commit 6bc9ca3. ± Comparison against base commit d2bff11. This pull request removes 3336 tests.♻️ This comment has been updated with latest results. |
vogella
changed the title
vogella
force-pushed
the
classpath-computation
branch
3 times, most recently
from
6a26333 to
d023d5c
Compare
Optimize access rule accumulation by using Set<Rule> instead of List<Rule> to avoid O(N) containment checks during insertion, which was causing O(N^2) complexity for plug-ins with many re-exported packages. Additionally, add a recursion guard in findExportedPackages to prevent infinite loops when processing cyclic re-exports in implicit or secondary dependencies.
This test verifies that classpath computation finishes quickly even when secondary dependencies form a cyclic re-export graph. Previously, this scenario caused an infinite loop in 'findExportedPackages', leading to a build hang. The new test 'testCyclicReexportInSecondaryDependencies' constructs such a cycle and asserts that computation completes within a reasonable time.
This test verifies performance in a chained re-export scenario (A->B->C->D, all re-exporting and exporting many packages) to ensure O(N) scaling and avoid redundant processing.
vogella
force-pushed
the
classpath-computation
branch
from
d023d5c to
6bc9ca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize access rule accumulation by using Set instead of List to avoid O(N) containment checks during insertion, which was causing O(N^2) complexity for plug-ins with many re-exported packages.
Additionally, add a recursion guard in findExportedPackages to prevent infinite loops when processing cyclic re-exports in implicit or secondary dependencies.