Fail if a workspace is disposed outside the manager#1532
Closed
laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
Closed
Fail if a workspace is disposed outside the manager#1532laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
Conversation
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
8e24948 to
7c521f8
Compare
Contributor
Author
|
One of the failing tests seem to be caused by this: |
59ea85b to
145fa0f
Compare
Currently one can obtain a workspace baseline and dispose it leading to hard to track errors. This now fails if someone tries to dispose the baseline without using the manager.
145fa0f to
77b7840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently one can obtain a workspace baseline and dispose it leading to hard to track errors.
This now fails if someone tries to dispose the baseline without using the manager.