Skip to content

rm printStacktrace and switch to slf4 api, dedup maven deps #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stbischof merged 1 commit into from
Oct 28, 2025
Merged

rm printStacktrace and switch to slf4 api, dedup maven deps #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@
</pluginRepositories>

<dependencies>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.eclipse.osgi-technology.command</groupId>
<artifactId>converter.bundle</artifactId>
Expand Down
8 changes: 6 additions & 2 deletions all/src/main/java/org/eclipse/osgi/technology/command/all/Activator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@
import org.osgi.framework.BundleActivator;
import org.osgi.framework.BundleContext;
import org.osgi.framework.Constants;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@Header(name = Constants.BUNDLE_ACTIVATOR, value = "${@class}")
@org.osgi.annotation.bundle.Capability(namespace = "org.apache.felix.gogo", name = "command.implementation", version = "1.0.0")
@org.osgi.annotation.bundle.Requirement(effective = "active", namespace = "org.apache.felix.gogo", name = "runtime.implementation", version = "1.0.0")
public class Activator implements BundleActivator {

private static final Logger logger = LoggerFactory.getLogger(Activator.class);

private List<BundleActivator> activators = List.of(
new org.eclipse.osgi.technology.command.converter.bundle.Activator(),
new org.eclipse.osgi.technology.command.converter.file.Activator(),
Expand All @@ -47,7 +51,7 @@ public void start(BundleContext context) throws Exception {
try {
a.start(context);
} catch (Exception e) {
e.printStackTrace();
logger.error("Failed to start activator: {}", a.getClass().getName(), e);
}

});
Expand All @@ -60,7 +64,7 @@ public void stop(BundleContext context) throws Exception {
try {
a.stop(context);
} catch (Exception e) {
e.printStackTrace();
logger.error("Failed to stop activator: {}", a.getClass().getName(), e);
}

});
Expand Down
6 changes: 0 additions & 6 deletions osgi.service.jakartars/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@
<artifactId>jakarta.json-api</artifactId>
<version>2.1.3</version>
</dependency>
<dependency>
<groupId>org.eclipse.osgi-technology.rest</groupId>
<artifactId>org.eclipse.osgitech.rest.jetty</artifactId>
<version>1.2.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.util.tracker</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions util/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,6 @@
<version>1.1.2</version>
</dependency>

<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.framework</artifactId>
</dependency>

<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.service.component.annotations</artifactId>
Expand Down
Loading