Enable inhibitRecompilation option for specific methods#23975
Draft
dev-koan wants to merge 3 commits into
Draft
Conversation
Currently, the option inhibitRecompilation is applied globally. This update enables the user to use the option for a specific method. Signed-off-by: Dev Agarwal <dev.agarwal@ibm.com>
mpirvu
reviewed
May 28, 2026
Contributor
mpirvu
left a comment
mpirvu
left a comment
There was a problem hiding this comment.
The code is on the right track. I am guessing that there are other code patch that trigger recompilations. We have to identify and address them.
You also need to do manual testing since no test is going to exercise this option.
Also, it may need changes at omr level to allow the option to be applied on a per method basis (remove NOT_IN_SUBSET)
| // promote this method through sample thresholds | ||
| } else // allow transition to HOT through exhaustion of count | ||
| { | ||
| if (_methodInfo->InhibitRecompilation()) { |
Contributor
There was a problem hiding this comment.
I am thinking that instead of returning we need to replenish the count like we do in the if statement above.
…y present if statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the option inhibitRecompilation is applied globally. This update enables the user to use the option for a specific method.
Fixes: #23902
Signed-off-by: Dev Agarwal dev.agarwal@ibm.com