Retry marker assertions after stale marker - #2227
Open
TyceHerrman wants to merge 1 commit into
Open
Conversation
TyceHerrman
force-pushed
the
issue-2224-retry-marker-assertions
branch
from
August 24, 2026 22:20
dff1c61 to
8b926af
Compare
TyceHerrman
marked this pull request as ready for review
August 24, 2026 22:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Retries
WorkspaceHelpers.assertMarker(...)once with a fresh marker snapshot when a marker disappears during inspection. UnrelatedCoreExceptions continue to propagate, and the existing missing-marker diagnostics are preserved.Adds focused coverage for stable markers, stale-marker replacement, bounded retry, unrelated failures, and missing-marker diagnostics.
Fixes #2224
How was this tested?
mvn -U -B -ntp clean integration-test -am -pl org.eclipse.m2e.core.tests -Dtest=WorkspaceHelpersTest -Dsurefire.failIfNoSpecifiedTests=false -P=-eclipse-sign-jnilibsResult: 5 tests, 0 failures, 0 errors, 0 skipped; all 10 reactor modules succeeded.
AI/GenAI disclosure
Checklist
mvn clean verify(add-Pitsfor integration tests) passes locally.