Simplify getMojoParameterValue usage and remove obsolete Plugin/ConfigurationContainer overload - #2222
Merged
Conversation
Plugin/ConfigurationContainer overload There where only two call sites left and both are unwrapping a mjoexecution. Passing the execution directly avoid to resolve it again.
Test Results 345 files ±0 345 suites ±0 1h 17m 53s ⏱️ +5s For more details on these failures and errors, see this check. Results for commit 2531123. ± Comparison against base commit 61ff447. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There where only two call sites left and both are unwrapping a mojoexecution. Passing the execution directly avoid to resolve it again.
Lets see if this works or if there is any subtile difference between the both here.