ignore insignificant licence change in baseline-check#1587
ignore insignificant licence change in baseline-check#1587fbricon wants to merge 1 commit intoeclipse-m2e:masterfrom
Conversation
Change-Id: I3667aef7789dc8d94c97ee685787c54a0982b8a7 Signed-off-by: Fred Bricon <[email protected]>
mickaelistria
left a comment
mickaelistria
left a comment
There was a problem hiding this comment.
See #1478 (comment) , I think we should favor other solutions.
|
I will not go over dozens of manifests and pom files to fix it |
| <ignore>jars/*.jar</ignore> | ||
| <ignore>Eclipse-SourceReferences</ignore> |
There was a problem hiding this comment.
Actually, even those shouldn't be ignored as they're supposed to be stable across rebuilds. And if they're not stable, then they should be made stable.
There was a problem hiding this comment.
Unfortunately they are not stable since they contain the ID of the commit from which the bundle was build.
There was a problem hiding this comment.
If configured correctly, the referenced commit is the last commit that has affected the particular module; which is stable as long as the bundle is not changed.
There was a problem hiding this comment.
That's a point.
But I likely added this because it failed the build, but if it would work without ignoring that, it would be even better.
|
CI ignores the directive anyway. Fuck it. |
|
The proper fix is just to bump bundle version as they now have different content. |
3 participants
Change-Id: I3667aef7789dc8d94c97ee685787c54a0982b8a7
Signed-off-by: Fred Bricon [email protected]