Do not execute Tests in sibling packages with common prefix#2566
Open
flori-schwa wants to merge 1 commit intoeclipse-jdt:masterfrom
Open
Do not execute Tests in sibling packages with common prefix#2566flori-schwa wants to merge 1 commit intoeclipse-jdt:masterfrom
flori-schwa wants to merge 1 commit intoeclipse-jdt:masterfrom
Conversation
flori-schwa
force-pushed
the
fschwabe/issues/2563
branch
from
7b81fcc to
52f9501
Compare
When launching JUnit Tests on a package, all Tests contained inside that
package (And nested packages) were launched.
However, Tests contained in sibling packages, that share the same
prefix, were also launched.
com
|
\-- example
|
\-- a <-- Launching JUnit Tests on this package
| |
| \-- nested
| | |
| | \-- MyNestedTest.java
| |
| \-- MyTest.java
| |
| \-- MyOtherTest.java
|
\-- ab
|
\-- MyTestInSiblingPackage.java <-- Was also executed
Now, only Tests contained in the target package, as well as Tests
contained in real child packages are launched.
Tests contained in sibling packages are no longer considered.
flori-schwa
force-pushed
the
fschwabe/issues/2563
branch
from
52f9501 to
6894861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Proposed Fix for #2563
Tests from sibling packages are no longer considered for Test Execution when launching JUnit Tests on a Java package.
How to test
Create the following package structure:
Right Click on the
com.example.apackage and select "Run As > JUnit Test".Only the
com.example.a.nested.MyNestedTest,com.example.a.MyOtherTestandcom.example.a.MyTestTests are launched. No Tests from thecom.example.abpackage are launchedAuthor checklist