Sort Profile settings by key when exporting#2448
Open
FlorianKroiss wants to merge 1 commit intoeclipse-jdt:masterfrom
Open
Sort Profile settings by key when exporting#2448FlorianKroiss wants to merge 1 commit intoeclipse-jdt:masterfrom
FlorianKroiss wants to merge 1 commit intoeclipse-jdt:masterfrom
Conversation
Author
|
Without this change it's hard to see which settings were changed when looking at a git diff of an exported Profile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
When exporting a profile, e.g. for cleanup or formatting, the order of the key/value pairs may be undefined, as they come from a HashMap. This change sorts the entries by key before creating the XML Profile Element.
How to test
Author checklist