Merge master into BETA_JAVA26#881
Open
jarthana wants to merge 9 commits intoeclipse-jdt:BETA_JAVA26from
Open
Conversation
…cution environment in test See: eclipse-jdt#782
During TestLogicalStructures, its possible that the test snippet triggers GC before the debug framework has called Interpreter.disableCollection() on objects created for the logical structure. In this case, the test fails with an ObjectCollectedException. This change adjusts how GC is performed in the test snippet of TestLogicalStructures. Instead of waiting a fixed amount of time in the snippet and then running GC, the tests now run GC with an evaluation, via JDI. This ensures that Interpreter.disableCollection() is called before GC is forced in the test snippet, avoiding potential sporadic failures. Fixes: eclipse-jdt#301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Author checklist