bazel: Enable bzlmod for iceoryx#2505
Closed
nicu1989 wants to merge 1 commit intoeclipse-iceoryx:mainfrom
Closed
Conversation
add build --noincompatible_disallow_empty_glob: packages contain glob patterns that resolve to nothing feature_acl flag off: dont fail on hosts that dont provide libacl build --noenable_bzlmod is removed so Bazel uses Bzlmod by default add bzlmod declarations to replace the old load_repositories() and setup_repositories() macros Signed-off-by: Nicolae Dicu <nicolae.dicu.ext@qorix.ai>
18 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2505 +/- ##
=======================================
Coverage 77.86% 77.86%
=======================================
Files 446 446
Lines 16301 16301
Branches 2320 2320
=======================================
Hits 12693 12693
Misses 2759 2759
Partials 849 849
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
@nicu1989 thanks for bringing this up. We are currently in the process to move the iceoryx_hoofs components, which are used by the iceoryx2 C++ bindings, to the iceoryx2 repo. Therefore, it would be better to wait a little bit until this is finished. Then only the PR in iceoryx2 is necessary and the iceoryx2 repo will be self contained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add build --noincompatible_disallow_empty_glob: packages contain glob patterns that resolve to nothing feature_acl flag off: dont fail on hosts that dont provide libacl build --noenable_bzlmod is removed so Bazel uses Bzlmod by default
add bzlmod declarations to replace the old load_repositories() and setup_repositories() macros
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch)iox-#123 commit text)task-list-completed)Checklist for the PR Reviewer
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txtPost-review Checklist for the PR Author
References