Skip to content

bazel: Enable bzlmod for iceoryx#2505

Closed
nicu1989 wants to merge 1 commit intoeclipse-iceoryx:mainfrom
qorix-group:nicu1989_enable_bzlmod_upstream
Closed

bazel: Enable bzlmod for iceoryx#2505
nicu1989 wants to merge 1 commit intoeclipse-iceoryx:mainfrom
qorix-group:nicu1989_enable_bzlmod_upstream

Conversation

@nicu1989
Copy link

add build --noincompatible_disallow_empty_glob: packages contain glob patterns that resolve to nothing feature_acl flag off: dont fail on hosts that dont provide libacl build --noenable_bzlmod is removed so Bazel uses Bzlmod by default

add bzlmod declarations to replace the old load_repositories() and setup_repositories() macros

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

  • Closes TBD

add build --noincompatible_disallow_empty_glob: packages contain glob patterns that resolve to nothing
feature_acl flag off: dont fail on hosts that dont provide libacl
build --noenable_bzlmod is removed so Bazel uses Bzlmod by default

add bzlmod declarations to replace the old load_repositories()
and setup_repositories() macros

Signed-off-by: Nicolae Dicu <nicolae.dicu.ext@qorix.ai>
@dkroenke dkroenke self-requested a review November 13, 2025 10:13
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.86%. Comparing base (f93a0e6) to head (6760c00).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2505   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         446      446           
  Lines       16301    16301           
  Branches     2320     2320           
=======================================
  Hits        12693    12693           
  Misses       2759     2759           
  Partials      849      849           
Flag Coverage Δ
unittests 77.69% <ø> (ø)
unittests_timing 15.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 189 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido
Copy link
Member

@nicu1989 thanks for bringing this up. We are currently in the process to move the iceoryx_hoofs components, which are used by the iceoryx2 C++ bindings, to the iceoryx2 repo. Therefore, it would be better to wait a little bit until this is finished. Then only the PR in iceoryx2 is necessary and the iceoryx2 repo will be self contained.

@nicu1989 nicu1989 closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants