[#1836] exclude META-INF/services from source jar in osgi#1844
Open
laurentschoelens wants to merge 1 commit intoeclipse-ee4j:masterfrom
Open
[#1836] exclude META-INF/services from source jar in osgi#1844laurentschoelens wants to merge 1 commit intoeclipse-ee4j:masterfrom
laurentschoelens wants to merge 1 commit intoeclipse-ee4j:masterfrom
Conversation
lukasj
reviewed
Feb 10, 2026
Member
lukasj
left a comment
lukasj
left a comment
There was a problem hiding this comment.
I believe there is no need to define plugin version as it is already defined in the parent.
Did you consider creating the correct OSGi source bundle? Even if not, sources jar should have appropriate OSGi headers in its manifest - at least Bundle-Symbolic-Name set to sth.source (or sth like that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1836
Configures maven-source-plugin to exclude the
META-INF/servicesfolder in OSGI bundle