Support for nestedLogit

[strengejacke]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily introduces compatibility for nestedLogit models within the modelbased package, expanding its utility for a broader range of statistical analyses. Alongside this functional enhancement, the changes also include significant code formatting adjustments to improve the clarity and structure of several core functions, making the codebase easier to understand and work with.

Highlights

• Nested Logit Model Support: Added support for models of class nestedLogit, allowing the package to handle predictions and estimations for these types of models.
• Code Formatting Improvements: Refactored function argument declarations and complex conditional statements in R/estimate_predicted.R for enhanced readability and maintainability.
• Version Update: The package version has been incremented from 0.14.0 to 0.14.0.1.

Changelog

• DESCRIPTION
  • Updated package version to 0.14.0.1.
• NEWS.md
  • Added a new entry under the 'devel' section to announce support for nestedLogit models.
• R/estimate_predicted.R
  • Refactored argument declarations for estimate_expectation, estimate_link, estimate_prediction, estimate_relation, and .estimate_predicted functions to improve readability.
  • Improved formatting of complex conditional statements for better code clarity.
  • Modified the handling of the 'Row' column in the output, specifically removing it for nestedLogit models while formatting it as an integer for other model types.
  • Reformatted argument passing to insight::get_datagrid and attribute/class assignments for consistency.

Activity

• No activity (comments, reviews, etc.) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for nestedLogit models and includes several code formatting improvements for better readability. The core logic change for nestedLogit support seems correct. However, there are a couple of minor style issues. The function definitions have been reformatted, but they don't fully adhere to the repository's style guide regarding the placement of curly braces. Additionally, one of the formatting changes consolidates a multi-line argument into a single line, which reduces readability and is inconsistent with the other formatting improvements. My review includes suggestions to address these points.